Skip to content

Support configurable testsuite and testcase names #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Support configurable testsuite and testcase names #105

wants to merge 15 commits into from

Conversation

grappler
Copy link

@grappler grappler commented Oct 3, 2025 •
edited by mpkorstanje
Loading

🤔 What's changed?

Two new methods to be able to change the naming strategy and feature name. Moved the default values to the first method.

⚡️ What's your motivation?

To be able to set the naming strategy for the XML report.
cucumber/cucumber-jvm#3087

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@grappler grappler mentioned this pull request Oct 3, 2025
Open
@grappler grappler changed the title Patch 1 Support configurable NamingStrategy.Strategy and NamingStrategy.FeatureName Oct 3, 2025
@grappler grappler changed the title Support configurable NamingStrategy.Strategy and NamingStrategy.FeatureName Support configurable NamingStrategy.Strategy and NamingStrategy.FeatureName in MessagesToJunitXmlWriter Oct 3, 2025
@vitalets
Copy link

vitalets commented Oct 4, 2025

Also relates to #74.

@grappler
Copy link
Author

grappler commented Oct 4, 2025

@vitalets Thank you for including that! I have added a JS solution, I hope you don't mind, as you were planning to work on a PR. Happy to get feedback.

@vitalets
Copy link

vitalets commented Oct 6, 2025

@vitalets Thank you for including that! I have added a JS solution, I hope you don't mind, as you were planning to work on a PR. Happy to get feedback.

Sure, thank you! I didn't get time for it(

mpkorstanje
mpkorstanje reviewed Oct 6, 2025
View reviewed changes
javascript/src/makeReport.ts Outdated
}

export function makeReport(query: Query): ReportSuite {
export function makeReport(query: Query, customNamingStrategy: NamingStrategy = NAMING_STRATEGY): ReportSuite {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't compile.

@mpkorstanje
Use builder pattern for the naming strategy
5b02cb1 
- Makes the whole naming strategy configurable
- Make suite name configurable
- Make test class name configurable
@mpkorstanje
Use custom naming in test
1283e54
@mpkorstanje
Copy link
Contributor

mpkorstanje commented Oct 6, 2025 •
edited
Loading

Pushed a few changes.

  1. Replaced the long constructors with a builder pattern. This makes it easier to deal with optional values.
  2. Add 1 test case that uses the builder. This did mean all the test cases had to be renamed to avoid collisions.

@grappler would you like to finish the Javascript implementation? Javascript can use default values so the builder can be omitted, but adding the testSuiteName and testClassName parameters as well as the tests should be added.

@mpkorstanje
Copy link
Contributor

@grappler ping! Are you still interested in working on this feature?

@grappler
Copy link
Author

@mpkorstanje Thank you for the ping. Sorry, I don't think I will be able to finish the JS implementation.

@mpkorstanje
Copy link
Contributor

mpkorstanje commented Oct 21, 2025 •
edited
Loading

@davidjgoss could you please take a look at the JS implementation and verify I didn't break any APIs?

@mpkorstanje mpkorstanje changed the title Support configurable NamingStrategy.Strategy and NamingStrategy.FeatureName in MessagesToJunitXmlWriter Support configurable testsuite name, testcase classname, and testcase name Oct 21, 2025
@mpkorstanje mpkorstanje changed the title Support configurable testsuite name, testcase classname, and testcase name Support configurable testsuite and testcase names Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpkorstanje mpkorstanje mpkorstanje left review comments

@davidjgoss davidjgoss Awaiting requested review from davidjgoss

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@grappler @vitalets @mpkorstanje